Improvement/osis 147 stop osis failure on decryption 7.10 #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds the capability of handling decryption faulire for secret key data stored in redis sentinel by the method `retrieveSecretKey` used by get and get credentials APIs. - Does not throw any error for any decryption failure - Logs all decryption failures - Removes the keys from Redis automatically for any decryption failure, the keys remain in vault and can be used the user if secret key is accessible (cherry picked from commit a76452e)
nicolas2bert
approved these changes
May 22, 2024
fredmnl
approved these changes
May 22, 2024
| } catch (Exception e) { | ||
| logger.error("Error: Unable to decrypt secret key data for Redis key: {}. Error details: {}", repoKey, e.getMessage()); | ||
| logger.debug("Full stack trace:", e); | ||
| deleteSecretKey(repoKey); |
There was a problem hiding this comment.
I'm not sure this is relevant but should we log something in case this fails?
There was a problem hiding this comment.
Yes we should, in fact we do not log anything for any redis operations.
I created a ticket for this tech debt: https://scality.atlassian.net/browse/S3C-8885
anurag4DSB
deleted the
improvement/OSIS-147-stop-osis-failure-on-decryption-7.10
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need this in 7.10.9 as well now so cherry picking from #141
I also changed the codeowners to match that of main